-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Rollup of 9 pull requests #146021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 9 pull requests #146021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, attempting to create/truncate a file without write/append access would result in platform-specific error messages: - Unix: "Invalid argument" - Windows: raw OS error code 87 These error codes look like system errors, which could waste hours of debugging for what is actually an API misuse issue.
We have a ui test to ensure we emit an error if we encounter too big enums. Before this fix, compiling the test with `-Cdebuginfo=2` would not include the span of the instantiation site, because the error is then emitted from a different code path that does not include the span. Propagate the span to the error also in the debuginfo case, so the test passes regardless of debuginfo level.
Android has supported pipe2 since 2010, long before the current min SDK.
…aheemdev std: clarify `OpenOptions` error for create without write access Fixes rust-lang#140621
…mulacrum std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.
…e_atomic_ptr, r=scottmcm Stabilize `strict_provenance_atomic_ptr` feature This closes [tracking issue](rust-lang#99108) and stabilises `AtomicPtr::{fetch_ptr_add, fetch_ptr_sub, fetch_byte_add, fetch_byte_sub, fetch_or, fetch_and, fetch_xor}` --- EDIT: FCP completed at rust-lang#99108 (comment)
…=scottmcm str: Stabilize `round_char_boundary` feature Closes rust-lang#93743 FCP completed rust-lang#93743 (comment)
…=wesleywiser compiler: Include span of too huge enum with `-Cdebuginfo=2` We have the ui test `tests/ui/limits/huge-enum.rs` to ensure we emit an error if we encounter too big enums. Before this fix, compiling the test with `-Cdebuginfo=2` would not include the span of the instantiation site, because the error is then emitted from a different code path that does not include the span. Propagate the span to the error also in the debuginfo case, so the test passes regardless of debuginfo level. I'm sure we can propagate spans in more places, but let's start small. ## Test failure without the fix Here is what the failure looks like if you run the test without the fix: ``` [ui] tests/ui/limits/huge-enum.rs#full-debuginfo ... F . failures: ---- [ui] tests/ui/limits/huge-enum.rs#full-debuginfo stdout ---- Saved the actual stderr to `/home/martin/src/rust/build/x86_64-unknown-linux-gnu/test/ui/limits/huge-enum.full-debuginfo/huge-enum.full-debuginfo.stderr` diff of stderr: 1 error: values of the type `Option<TYPE>` are too big for the target architecture - --> $DIR/huge-enum.rs:17:9 - | - LL | let big: BIG = None; - | ^^^ 6 7 error: aborting due to 1 previous error 8 The actual stderr differed from the expected stderr To update references, rerun the tests and pass the `--bless` flag To only update this specific test, also pass `--test-args limits/huge-enum.rs` ``` as can be seen, the `span` used to be missing with `debuginfo=2`. ## See also This is one small step towards resolving rust-lang#61117. cc rust-lang#144499 which began running UI tests with `rust.debuginfo-level-tests=1`. This PR is part of preparing for increasing that to debuglevel 2.
`AutoDeref::final_ty` is already resolved What is a `bool` argument doing here :< The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130 For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82 While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
std: haiku: fix `B_FIND_PATH_IMAGE_PATH` Fixes rust-lang#145952, which was caused by rust-lang/libc#4575 `````@rustbot````` label T-libs O-haiku
…vement, r=notriddle Improve librustdoc error when a file creation/modification failed The message before looks like this: ``` failed to create or modify "/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/search.index/entry/" ``` And with this change it looks like this: ``` failed to create or modify "/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/search.index/entry/": failed to read column from disk: data consumer error: missing field `unknown number` at line 1 column 8 ``` r? ````@lolbinarycat````
Mark pipe2 supported in Android Android has supported pipe2 since 2010, long before the current min SDK.
@bors r+ rollup=never p=5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
O-unix
Operating system: Unix-like
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
OpenOptions
error for create without write access #144964 (std: clarifyOpenOptions
error for create without write access)SplitPaths
on UNIX #145242 (std: use a TAIT to defineSplitPaths
on UNIX)strict_provenance_atomic_ptr
feature #145467 (Stabilizestrict_provenance_atomic_ptr
feature)round_char_boundary
feature #145756 (str: Stabilizeround_char_boundary
feature)-Cdebuginfo=2
#145967 (compiler: Include span of too huge enum with-Cdebuginfo=2
)AutoDeref::final_ty
is already resolved #145990 (AutoDeref::final_ty
is already resolved)B_FIND_PATH_IMAGE_PATH
#145991 (std: haiku: fixB_FIND_PATH_IMAGE_PATH
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup